[ENH] add functionality to send later scheduled sending #1091

amaninyumu1 · 2024-06-15T20:08:32Z

marclaporte · 2024-06-17T23:14:07Z

Will this work with JMAP as well?

kroky · 2024-06-20T08:38:27Z

Yes, anything we add for IMAP, we should check JMAP support as well. Overall, it is built on top of IMAP, so it should work but please check if the new Scheduled folder is OK for JMAP.

Overall, the code is good but I have one concern - it only sends out while you are actively using Cypht and it seems to warn of unsent/scheduled messages each time you leave a page (onbeforeunload). That would be annoying for the end user. I believe this comment #576 (comment) proposes using sendAt support from jmap servers or scheduled send - if it is supported, we use it, if not, we fallback to a more annoying option. At any rate, it should be configurable.

This could be fully-supported in the Cypht-Tiki integration where there could be a Tiki command run periodically in the scheduler that checks and sends scheduled messages.

josaphatim · 2024-06-27T11:12:29Z

@kroky I added a commit to fix issue concerning onbeforeunload event and also add the option to change schedule time or send the message immediately. Can you check please.

marclaporte · 2024-07-29T15:16:53Z

@amaninyumu1 If you need help with JMAP, please reach out to @Shadow243 as he set up a JMAP server for testing.

marclaporte · 2024-08-25T09:24:15Z

@amaninyumu1 "This branch has conflicts that must be resolved"

marclaporte · 2024-10-21T13:35:35Z

@amaninyumu1 This branch has conflicts that must be resolved

amaninyumu1 · 2024-10-22T20:07:04Z

Hello @marclaporte , @kroky I resolved the conflicts. please review

modules/smtp/modules.php

kroky · 2024-10-23T12:02:26Z

modules/smtp/modules.php

+                            }
+                        } catch (Exception $e) {
+                            Hm_Debug::add(sprintf('ERRCannot send message: %s', $msg_headers['subject']));
+                        if (send_scheduled_message($this, $imap, $msg, $server_id)) {


If you retry sending in some other way, combine the above sending with the one in this method, so we don't repeat so much code.

kroky · 2024-10-23T12:04:04Z

modules/smtp/modules.php

+}}
+
+if (!hm_exists('reschedule_message_sending')) {
+function reschedule_message_sending($handler, $imap, $msg_id, $folder, $new_date, $server_id) {


Use modules.php only for handle or output modules. Move the functions to its own functions.php file to keep the existing structure in other modules (e.g. imap and core).

kroky · 2024-10-23T12:05:22Z

There are still conflicts and I believe big part of the reason is #1266 - @jacob-js , can you check if some handlers in this PR need to be updated according to the router changes you did in 1266?

jacob-js · 2024-10-24T12:52:56Z

modules/imap/site.js

+        class_name = 'imap_' + detail.server_id + '_' + msg_uid + '_' + detail.folder;
+        if (hm_list_parent() === 'combined_inbox') {
+            Hm_Message_List.prev_next_links('formatted_combined_inbox', class_name);
+        }
+        else if (hm_list_parent() === 'unread') {
+            Hm_Message_List.prev_next_links('formatted_unread_data', class_name);
+        }
+        else if (hm_list_parent() === 'flagged') {
+            Hm_Message_List.prev_next_links('formatted_flagged_data', class_name);
+        }
+        else if (hm_list_parent() === 'advanced_search') {
+            Hm_Message_List.prev_next_links('formatted_advanced_search_data', class_name);
+        }
+        else if (hm_list_parent() === 'search') {
+            Hm_Message_List.prev_next_links('formatted_search_data', class_name);
+        }
+        else if (hm_list_parent() === 'sent') {
+            Hm_Message_List.prev_next_links('formatted_sent_data', class_name);
+        }
+        else if (hm_list_parent() === 'junk') {
+            Hm_Message_List.prev_next_links('formatted_junk_data', class_name);
+        }
+        else if (hm_list_parent() === 'trash') {
+            Hm_Message_List.prev_next_links('formatted_trash_data', class_name);
+        }
+        else if (hm_list_parent() === 'drafts') {
+            Hm_Message_List.prev_next_links('formatted_drafts_data', class_name);
+        }
+        else if (hm_list_parent() === 'tag') {
+            Hm_Message_List.prev_next_links('formatted_tag_data', class_name);
+        }
+        else {
+            var key = 'imap_' + Hm_Utils.get_url_page_number() + '_' + getListPathParam();
+            Hm_Message_List.prev_next_links(key, class_name);
+        }


This rebase isn't accurate. Master has passed over these changes.

@amaninyumu1 I think you should be careful merging the changes from master - there are conflicts because of the upstream changes and these need to be merged correctly (keep the master ones and copy your code to the relevant places).

jacob-js · 2024-10-24T12:55:35Z

modules/imap/site.js

    if (!uid) {
        uid = getMessageUidParam();
    }
-    const callbackFn = (...args) => {        


Could you avoid such changes in the future? it's really difficult to focus on what has actually changed.

jacob-js · 2024-10-24T13:01:12Z

The small piece of code added won't need an update since it is not executed on page loads.

jacob-js · 2024-10-28T09:25:11Z

modules/core/site.js

+var sprintf = function(format, ...args) {
+    let i = 0;
+    return format.replace(/%([sd])/g, (match, type) => {
+        let arg = args[i++];
+        switch (type) {
+            case 's': return String(arg);
+            case 'd': return Number(arg);
+            default: return match;
+        }
+    });
+}
+


I don't think this is necessary. If including variables in a string is all you need, you can use template literals.

jacob-js · 2024-10-28T09:30:39Z

modules/core/site.js

@@ -2012,6 +2025,12 @@ $(function() {
        try { navigator.registerProtocolHandler("mailto", "?page=compose&compose_to=%s", "Cypht"); } catch(e) {}
    }

+    if (hm_page_name() == 'home') {
+        $('.pw_update').on("click", function() { update_password($(this).data('id')); });


I see the same statement already in route_handlers.js. So, you don't need to have it here anymore besides the fact that adding handlers based on the hm_page_name() is already outdated in favor of the route handlers in each module.

@jacob-js I made some modifications by removing the hm_page_name() in the core module js file. please review

jacob-js · 2024-10-28T09:32:11Z

modules/core/site.js

+        $('.pw_update').on("click", function() { update_password($(this).data('id')); });
+    }
+    if (hm_page_name() == 'servers') {
+        $('.edit_server_connection').on('click', imap_smtp_edit_action);


You should do the same here. Check if the statement is not yet in the serversPageHandlers and move it to there.

jacob-js · 2024-10-28T09:33:57Z

modules/imap/site.js

+    if (hm_page_name() === 'message_list' && hm_list_path().substr(0, 4) === 'imap') {
+        setup_imap_folder_page();
+    }
+    else if (hm_page_name() === 'message_list' && hm_list_path() === 'combined_inbox') {
+        setup_imap_message_list_content_page();
+    }
+    else if (hm_page_name() === 'message' && hm_list_path().substr(0, 4) === 'imap') {
+        imap_setup_message_view_page();
+    }
+    else if (hm_page_name() === 'servers') {
+        imap_setup_server_page();
+    }
+    else if (hm_page_name() === 'info') {
+        setTimeout(imap_status_update, 100);
+    }


All of this should not be here anymore.

jacob-js · 2024-10-28T09:34:41Z

modules/imap/site.js

+    if (hm_page_name() === 'message_list' || hm_page_name() === 'message') {
+        imap_setup_snooze();
+        imap_setup_tags();
+        setup_nexter_date(function(e) {


Move this function call to the appropriate page handlers

jacob-js · 2024-10-28T09:39:22Z

modules/smtp/site.js

@@ -427,3 +436,264 @@ function smtpSettingsPageHandler() {
        );
    });
 }
+$(function () {


master has passed over these changes. If you have additional lines of code, ensure they are in the right route handlers.

amaninyumu1 · 2024-10-30T10:05:53Z

Hello @jacob-js I don't understand very well please

jacob-js · 2024-10-30T19:31:24Z

Hello @jacob-js I don't understand very well please

I added more details in your inbox, I hope it becomes clear!

amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 7aaffb2 to 0c58a6a Compare June 16, 2024 14:58

amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 0c58a6a to 0aef136 Compare June 19, 2024 08:09

josaphatim requested a review from kroky June 19, 2024 08:12

amaninyumu1 marked this pull request as ready for review June 19, 2024 08:12

josaphatim force-pushed the Cypht-delay-send-later-scheduled-sending branch 2 times, most recently from 36599a8 to 2da4ff4 Compare June 27, 2024 13:45

amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch 2 times, most recently from 45374ae to bdf9d5d Compare July 29, 2024 20:29

Baraka24 force-pushed the Cypht-delay-send-later-scheduled-sending branch 5 times, most recently from cf0574d to af1c185 Compare August 2, 2024 10:21

amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch 2 times, most recently from 141f8d9 to 16293f5 Compare September 14, 2024 06:13

amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 16293f5 to 41c9b95 Compare September 26, 2024 06:16

amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 41c9b95 to 3fb7802 Compare October 8, 2024 02:47

amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 3fb7802 to e725bcc Compare October 22, 2024 19:54

kroky reviewed Oct 23, 2024

View reviewed changes

modules/smtp/modules.php Show resolved Hide resolved

kroky reviewed Oct 23, 2024

View reviewed changes

modules/smtp/modules.php Outdated Show resolved Hide resolved

kroky reviewed Oct 23, 2024

View reviewed changes

amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from e725bcc to e3825fe Compare October 24, 2024 12:01

jacob-js reviewed Oct 24, 2024

View reviewed changes

amaninyumu1 closed this Oct 24, 2024

amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from e3825fe to 729dc43 Compare October 24, 2024 19:40

[ENH] add functionality to send later scheduled sending

b2f879d

amaninyumu1 reopened this Oct 25, 2024

amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from b34ef74 to bbf3b65 Compare October 26, 2024 10:58

jacob-js reviewed Oct 28, 2024

View reviewed changes

amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from bbf3b65 to 5f0695c Compare October 30, 2024 09:50

amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 5f0695c to 740bf92 Compare October 30, 2024 14:37

[ENH]add Cypht-delay-send-later-scheduled-sending

4698358

amaninyumu1 force-pushed the Cypht-delay-send-later-scheduled-sending branch from 740bf92 to 4698358 Compare October 30, 2024 20:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ENH] add functionality to send later scheduled sending #1091

[ENH] add functionality to send later scheduled sending #1091

amaninyumu1 commented Jun 15, 2024

marclaporte commented Jun 17, 2024

kroky commented Jun 20, 2024

josaphatim commented Jun 27, 2024

marclaporte commented Jul 29, 2024

marclaporte commented Aug 25, 2024

marclaporte commented Oct 21, 2024

amaninyumu1 commented Oct 22, 2024

kroky Oct 23, 2024

kroky Oct 23, 2024

kroky commented Oct 23, 2024

jacob-js Oct 24, 2024

kroky Oct 24, 2024

jacob-js Oct 24, 2024

jacob-js commented Oct 24, 2024

jacob-js Oct 28, 2024

jacob-js Oct 28, 2024

amaninyumu1 Oct 30, 2024

jacob-js Oct 28, 2024

jacob-js Oct 28, 2024

jacob-js Oct 28, 2024 •

edited

Loading

jacob-js Oct 28, 2024

amaninyumu1 commented Oct 30, 2024

jacob-js commented Oct 30, 2024

[ENH] add functionality to send later scheduled sending #1091

Are you sure you want to change the base?

[ENH] add functionality to send later scheduled sending #1091

Conversation

amaninyumu1 commented Jun 15, 2024

marclaporte commented Jun 17, 2024

kroky commented Jun 20, 2024

josaphatim commented Jun 27, 2024

marclaporte commented Jul 29, 2024

marclaporte commented Aug 25, 2024

marclaporte commented Oct 21, 2024

amaninyumu1 commented Oct 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kroky commented Oct 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jacob-js commented Oct 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jacob-js Oct 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amaninyumu1 commented Oct 30, 2024

jacob-js commented Oct 30, 2024

jacob-js Oct 28, 2024 •

edited

Loading